mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 23:33:29 +00:00
fix(coach): show the operator's central Codex when it answers
The operator's shared Codex is appended to the resolved chain but is never a chain entry, so the Coach's provider select had no option for it and showed its first option as the one answering. The answering provider now appears as a disabled option, with a note that the operator manages the connection.
This commit is contained in:
1 parent
2a556b47c3
commit
0c1dd1e967
9 files changed
+70
-9
No files matched your search
@@ -43,11 +43,11 @@ const PROVIDER: UserAIProvider = {
|
||||
compatReasoningEffort: null,
|
||||
};
|
||||
|
||||
function render(node: React.ReactNode) {
|
||||
function render(node: React.ReactNode, chain: ProviderChainData = CHAIN) {
|
||||
const client = new QueryClient({
|
||||
defaultOptions: { queries: { retry: false } },
|
||||
});
|
||||
client.setQueryData(queryKeys.insightsProviderChain(), CHAIN);
|
||||
client.setQueryData(queryKeys.insightsProviderChain(), chain);
|
||||
client.setQueryData(queryKeys.userAiProvider(), PROVIDER);
|
||||
client.setQueryData(queryKeys.coachPrefs(), DEFAULT_COACH_PREFS);
|
||||
return renderToStaticMarkup(
|
||||
@@ -81,6 +81,23 @@ describe("<CoachSettingsBody>", () => {
|
||||
expect(select).not.toContain('value="codex"');
|
||||
});
|
||||
|
||||
it("shows the operator's central Codex as the active provider when it answers", () => {
|
||||
// `admin-codex` is never a chain entry, so no option matched it and the
|
||||
// select showed its first option as the one answering.
|
||||
const html = render(<CoachSettingsBody />, {
|
||||
...CHAIN,
|
||||
activeProvider: "admin-codex" as ProviderChainData["activeProvider"],
|
||||
});
|
||||
const select = html.match(
|
||||
/<select[^>]*data-slot="coach-quick-provider"[\s\S]*?<\/select>/,
|
||||
)?.[0];
|
||||
expect(select).toMatch(
|
||||
/<option value="admin-codex" disabled="" selected="">ChatGPT \(shared by the operator\)<\/option>/,
|
||||
);
|
||||
expect(select).not.toMatch(/value="local"[^>]*selected/);
|
||||
expect(html).toContain('data-slot="coach-quick-provider-operator"');
|
||||
});
|
||||
|
||||
it("shows the model and reasoning controls the active provider owns", () => {
|
||||
const html = render(<CoachSettingsBody />);
|
||||
expect(html).toContain('data-slot="coach-quick-model"');
|
||||
|
||||
@@ -82,6 +82,19 @@ export function switchDidNotTake(
|
||||
return fresh.activeProvider !== chosen;
|
||||
}
|
||||
|
||||
/**
|
||||
* The provider the server answers with when the select has no option for it:
|
||||
* the operator's central Codex (never a chain entry), or an entry that answers
|
||||
* without being offered. Shown as a disabled option so the select tells the
|
||||
* truth instead of showing its first option as active.
|
||||
*/
|
||||
export function activeOutsideOptions(
|
||||
active: string | null,
|
||||
options: readonly string[],
|
||||
): string | null {
|
||||
return active !== null && !options.includes(active) ? active : null;
|
||||
}
|
||||
|
||||
export type ModelControl =
|
||||
| { kind: "preset"; presets: readonly string[]; value: string | null }
|
||||
| { kind: "gateway"; value: string | null }
|
||||
@@ -201,6 +214,8 @@ export function CoachModelPicker() {
|
||||
const model = modelControlFor(active, userProvider);
|
||||
const reasoning = reasoningFieldFor(active, userProvider);
|
||||
const busy = switchProvider.isPending || patchProvider.isPending;
|
||||
// The server may answer with `admin-codex`, which the UI's type omits.
|
||||
const unlisted = activeOutsideOptions(active as string | null, options);
|
||||
|
||||
if (chainQuery.isError || providerQuery.isError) {
|
||||
return (
|
||||
@@ -259,12 +274,27 @@ export function CoachModelPicker() {
|
||||
{t("insights.coach.frame.noProvider")}
|
||||
</option>
|
||||
) : null}
|
||||
{unlisted ? (
|
||||
<option value={unlisted} disabled>
|
||||
{unlisted === "admin-codex"
|
||||
? t("insights.coach.frame.operatorCodex")
|
||||
: t(`settings.ai.providerChain.types.${unlisted}`)}
|
||||
</option>
|
||||
) : null}
|
||||
{options.map((p) => (
|
||||
<option key={p} value={p}>
|
||||
{t(`settings.ai.providerChain.types.${p}`)}
|
||||
</option>
|
||||
))}
|
||||
</NativeSelect>
|
||||
{unlisted === "admin-codex" ? (
|
||||
<p
|
||||
data-slot="coach-quick-provider-operator"
|
||||
className="text-muted-foreground mt-1 text-xs"
|
||||
>
|
||||
{t("insights.coach.frame.operatorManaged")}
|
||||
</p>
|
||||
) : null}
|
||||
</div>
|
||||
|
||||
{model.kind === "preset" ? (
|
||||
|
||||
Reference in new issue
Block a user