fix(integrations): a provider with no history is "unknown"

The ledger's synthetic "no row" snapshot returned `state: "connected"`, so
the field's default meant the opposite of its name: every account that had
never connected a provider published `connected` on the status envelope.
Settings survived it by never reading `state`; the setup flow's connect step
did read it, and told brand-new accounts their wearable was connected.

The snapshot now reads `unknown`. `syncHealth.verdict` is unchanged and stays
the only liveness truth; the managed-record projection maps `unknown` onto
`disconnected` the way it already maps a missing connection.
This commit is contained in:
Marc-André Bombeck committed 2026-09-11 09:08:38 +02:00
1 parent 274923a060
commit 0bdbf009f6
8 files changed
+126 -23

No files matched your search

@@ -63,6 +63,7 @@ import {
IntegrationErrorMessage,
pillFailurePropsFor,
pillStateForVerdict,
type IntegrationState,
} from "./shared";
import {
CallbackMismatchNotice,
@@ -78,12 +79,12 @@ export interface OAuthProviderStatus {
available: boolean;
/** Whether the user has stored their own BYO client id/secret pair. */
hasOwnCredentials?: boolean;
state?:
| "connected"
| "error_transient"
| "error_reauth"
| "disconnected"
| "parked";
/**
* The raw ledger state, carried for shape parity with the envelope. The
* card paints from `syncHealth.verdict`, never from this — which is why
* v1.38.19's `unknown` member needs no arm here.
*/
state?: IntegrationState;
lastSuccessAt?: string | null;
lastAttemptAt?: string | null;
lastError?: string | null;
@@ -36,8 +36,16 @@ export type IntegrationKey =
// Nightscout folds onto the envelope so the card stops fetching its own
// status and inherits the shared verdict.
| "nightscout";
/** Mirrors `IntegrationState` in `src/lib/integrations/status.ts`. */
export type IntegrationState =
"connected" | "error_transient" | "error_reauth" | "disconnected" | "parked";
| "connected"
| "error_transient"
| "error_reauth"
| "disconnected"
| "parked"
// v1.38.19 — no ledger row: the ledger has no history for this provider.
// Read like `disconnected`; `syncHealth.verdict` owns liveness.
| "unknown";
export interface IntegrationStatusViewModel {
integration: IntegrationKey;