From 0b3c013af719bf7ae1b6f514da32101d487f1b8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Bombeck?= Date: Wed, 11 Nov 2026 00:49:02 +0100 Subject: [PATCH] fix(i18n): name the period in the forecast style hints Only the selected style's hint is shown, so "it may start" and "they may fall" had no noun on screen to point back to. Name the period in every locale that left it implied, and put the Korean hints in the same register as the rest of the card. --- messages/en.json | 4 ++-- messages/es.json | 4 ++-- messages/fr.json | 2 +- messages/it.json | 4 ++-- messages/ko.json | 6 +++--- messages/nl.json | 4 ++-- messages/pl.json | 2 +- messages/pt-BR.json | 4 ++-- messages/ru.json | 2 +- .../cycle/__tests__/cycle-calendar-feed-card.test.tsx | 6 ++++-- 10 files changed, 20 insertions(+), 18 deletions(-) diff --git a/messages/en.json b/messages/en.json index 9e7437925..6a5c05ac9 100644 --- a/messages/en.json +++ b/messages/en.json @@ -10085,8 +10085,8 @@ }, "forecastStyleHint": { "EXACT": "Just the expected days.", - "MARGIN": "Expected days, with the days it may start earlier or later as separate entries.", - "BAND": "One entry covering every day it may fall on." + "MARGIN": "Expected days, with the days the period may start earlier or later as separate entries.", + "BAND": "One entry covering every day the period may fall on." }, "fertile": "Fertile window", "fertileDescription": "Adds the estimated fertile window of the next cycle. An estimate, not a contraceptive method.", diff --git a/messages/es.json b/messages/es.json index ed699f11e..a2b612bad 100644 --- a/messages/es.json +++ b/messages/es.json @@ -10085,8 +10085,8 @@ }, "forecastStyleHint": { "EXACT": "Solo los días previstos.", - "MARGIN": "Los días previstos, con los días en que puede empezar antes o después como eventos aparte.", - "BAND": "Un solo evento que cubre todos los días en que puede caer." + "MARGIN": "Los días previstos, con los días en que el periodo puede empezar antes o después como eventos aparte.", + "BAND": "Un solo evento que cubre todos los días en que puede caer el periodo." }, "fertile": "Ventana fértil", "fertileDescription": "Añade la ventana fértil estimada del próximo ciclo. Una estimación, no un método anticonceptivo.", diff --git a/messages/fr.json b/messages/fr.json index ee58ad000..af97df036 100644 --- a/messages/fr.json +++ b/messages/fr.json @@ -10086,7 +10086,7 @@ "forecastStyleHint": { "EXACT": "Seulement les jours prévus.", "MARGIN": "Les jours prévus, avec en événements séparés les jours où les règles peuvent commencer plus tôt ou plus tard.", - "BAND": "Un seul événement couvrant tous les jours où elles peuvent tomber." + "BAND": "Un seul événement couvrant tous les jours où les règles peuvent tomber." }, "fertile": "Fenêtre fertile", "fertileDescription": "Ajoute la fenêtre fertile estimée du prochain cycle. Une estimation, pas une méthode contraceptive.", diff --git a/messages/it.json b/messages/it.json index dd6ed5138..fed51449c 100644 --- a/messages/it.json +++ b/messages/it.json @@ -10085,8 +10085,8 @@ }, "forecastStyleHint": { "EXACT": "Solo i giorni previsti.", - "MARGIN": "I giorni previsti, con i giorni in cui possono iniziare prima o dopo come eventi separati.", - "BAND": "Un unico evento che copre tutti i giorni in cui possono cadere." + "MARGIN": "I giorni previsti, con i giorni in cui le mestruazioni possono iniziare prima o dopo come eventi separati.", + "BAND": "Un unico evento che copre tutti i giorni in cui possono cadere le mestruazioni." }, "fertile": "Finestra fertile", "fertileDescription": "Aggiunge la finestra fertile stimata del prossimo ciclo. Una stima, non un metodo contraccettivo.", diff --git a/messages/ko.json b/messages/ko.json index 07e82b974..77eee65e5 100644 --- a/messages/ko.json +++ b/messages/ko.json @@ -10084,9 +10084,9 @@ "BAND": "하나의 기간" }, "forecastStyleHint": { - "EXACT": "예상되는 날만 표시합니다.", - "MARGIN": "예상일과 함께, 더 일찍 또는 늦게 시작할 수 있는 날을 별도 일정으로 표시합니다.", - "BAND": "생리가 있을 수 있는 모든 날을 하나의 일정으로 표시합니다." + "EXACT": "예상되는 날만 보여줘요.", + "MARGIN": "예상일과 함께, 더 일찍 또는 늦게 시작할 수 있는 날을 별도 일정으로 보여줘요.", + "BAND": "생리가 있을 수 있는 모든 날을 하나의 일정으로 보여줘요." }, "fertile": "가임기", "fertileDescription": "다음 주기의 예상 가임기를 추가해요. 추정일 뿐 피임 방법이 아니에요.", diff --git a/messages/nl.json b/messages/nl.json index 70a91d880..1df8e98bf 100644 --- a/messages/nl.json +++ b/messages/nl.json @@ -10085,8 +10085,8 @@ }, "forecastStyleHint": { "EXACT": "Alleen de verwachte dagen.", - "MARGIN": "De verwachte dagen, met de dagen waarop ze eerder of later kan beginnen als aparte afspraken.", - "BAND": "Eén afspraak over alle dagen waarop ze kan vallen." + "MARGIN": "De verwachte dagen, met de dagen waarop de menstruatie eerder of later kan beginnen als aparte afspraken.", + "BAND": "Eén afspraak over alle dagen waarop de menstruatie kan vallen." }, "fertile": "Vruchtbare periode", "fertileDescription": "Voegt de geschatte vruchtbare periode van de volgende cyclus toe. Een schatting, geen anticonceptiemethode.", diff --git a/messages/pl.json b/messages/pl.json index 1b7aa0d98..fa9457d77 100644 --- a/messages/pl.json +++ b/messages/pl.json @@ -10086,7 +10086,7 @@ "forecastStyleHint": { "EXACT": "Tylko przewidywane dni.", "MARGIN": "Przewidywane dni, a jako osobne wydarzenia dni, w które miesiączka może zacząć się wcześniej lub później.", - "BAND": "Jedno wydarzenie obejmujące wszystkie dni, na które może przypaść." + "BAND": "Jedno wydarzenie obejmujące wszystkie dni, na które może przypaść miesiączka." }, "fertile": "Okno płodne", "fertileDescription": "Dodaje szacowane okno płodne następnego cyklu. To szacunek, nie metoda antykoncepcji.", diff --git a/messages/pt-BR.json b/messages/pt-BR.json index bfc4635be..6abf9a204 100644 --- a/messages/pt-BR.json +++ b/messages/pt-BR.json @@ -10085,8 +10085,8 @@ }, "forecastStyleHint": { "EXACT": "Só os dias previstos.", - "MARGIN": "Os dias previstos, com os dias em que ela pode começar antes ou depois como eventos separados.", - "BAND": "Um único evento cobrindo todos os dias em que ela pode cair." + "MARGIN": "Os dias previstos, com os dias em que a menstruação pode começar antes ou depois como eventos separados.", + "BAND": "Um único evento cobrindo todos os dias em que a menstruação pode cair." }, "fertile": "Janela fértil", "fertileDescription": "Adiciona a janela fértil estimada do próximo ciclo. Uma estimativa, não um método contraceptivo.", diff --git a/messages/ru.json b/messages/ru.json index 2324e9e46..159cf4fab 100644 --- a/messages/ru.json +++ b/messages/ru.json @@ -10086,7 +10086,7 @@ "forecastStyleHint": { "EXACT": "Только ожидаемые дни.", "MARGIN": "Ожидаемые дни, а отдельными событиями дни, когда месячные могут начаться раньше или позже.", - "BAND": "Одно событие на все дни, на которые они могут прийтись." + "BAND": "Одно событие на все дни, на которые могут прийтись месячные." }, "fertile": "Фертильное окно", "fertileDescription": "Добавляет предполагаемое фертильное окно следующего цикла. Это оценка, а не метод контрацепции.", diff --git a/src/components/cycle/__tests__/cycle-calendar-feed-card.test.tsx b/src/components/cycle/__tests__/cycle-calendar-feed-card.test.tsx index da7782cab..d113f7165 100644 --- a/src/components/cycle/__tests__/cycle-calendar-feed-card.test.tsx +++ b/src/components/cycle/__tests__/cycle-calendar-feed-card.test.tsx @@ -71,7 +71,7 @@ describe("", () => { } expect(html).toContain('aria-describedby="cycle-feed-forecast-hint"'); expect(html).toMatch( - /data-slot="cycle-feed-forecast-hint"[^>]*>Expected days, with the days it may start earlier or later as separate entries\.]*>Expected days, with the days the period may start earlier or later as separate entries\.", () => { projectionState: "OK", fertileAvailable: false, }); - expect(band).toContain("One entry covering every day it may fall on."); + expect(band).toContain( + "One entry covering every day the period may fall on.", + ); expect(band).not.toContain("as separate entries"); });