mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-17 07:42:23 +00:00
fix(crypto): walk every encrypted column in bounded pages
Key rotation and the rotation status read every column that was not flagged as a blob with one `findMany` over the whole table. `Measurement.notesEncrypted` and `MoodEntry.noteEncrypted` are such columns, so rotation loaded every measurement of the instance: 1.25 million rows on one large account (#1031), and the rotation status page did the same on every view. Every column is now walked with the id-cursor pages the blob columns already used: 25 rows a page for blobs, 5 000 for everything else. The maintenance script's own per-column walks page the same way. On the seeded account with 1 460 notes to rotate, peak heap fell from 272 MB to 153 MB, and it no longer grows with the table. `scanned` now counts the rows that hold ciphertext for every column, as it already did for the blob columns, rather than every row of the table for some columns and only the ciphertext rows for others. The runbook says so.
This commit is contained in:
1 parent
7071fa91af
commit
0a54a43799
4 files changed
+154
-104
No files matched your search
@@ -60,8 +60,10 @@ under `v1` (the synthetic id assigned to the existing `ENCRYPTION_KEY`).
|
||||
|
||||
Read three things off the output before going further:
|
||||
|
||||
- the per-column line, `scanned` / `rotated` / `errors` / `dropped`. Treat
|
||||
`errors > 0` as a hard failure and re-run after fixing the cause. A
|
||||
- the per-column line, `scanned` / `rotated` / `errors` / `dropped`.
|
||||
`scanned` counts the rows that hold ciphertext in that column, not every
|
||||
row of the table. Treat `errors > 0` as a hard failure and re-run after
|
||||
fixing the cause. A
|
||||
`dropped` count is only ever a cache row the run could not read and
|
||||
deleted rather than leave unreadable.
|
||||
- `Columns walked: N/M registered`. The two numbers must match.
|
||||
|
||||
Reference in new issue
Block a user