mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-19 08:12:52 +00:00
fix(settings): unlist Preview features until the topic pages ship
The switch was stored and shown, but nothing reads the topics flag yet, so the page promised a change it could not make. The section, its nav entry, its loader and its copy are gone, so its palette entry goes with them; /settings/preview is no longer a route. The stored flag, /api/settings/preview-features and its backup round-trip stay, and the column's pending-consumer note says why.
This commit is contained in:
1 parent
704822c010
commit
0918451e02
21 files changed
+23
-327
No files matched your search
@@ -1,11 +1,10 @@
|
||||
/**
|
||||
* Copy that promises something not yet shipped says so.
|
||||
*
|
||||
* The Topics preview switch exists before its pages do, so its description is
|
||||
* in the future tense in every locale's source (English) and in German; and
|
||||
* the workout-route switch is off for new accounts, which is what its detail
|
||||
* The workout-route switch is off for new accounts, which is what its detail
|
||||
* says rather than "off by default": an account that already held tracks at
|
||||
* the upgrade started with it on (migration 0434).
|
||||
* the upgrade started with it on (migration 0434). (The Topics preview switch
|
||||
* this file also held is unlisted until its pages ship, and its copy with it.)
|
||||
*/
|
||||
import { describe, expect, it } from "vitest";
|
||||
|
||||
@@ -13,11 +12,6 @@ import en from "../../messages/en.json";
|
||||
import de from "../../messages/de.json";
|
||||
|
||||
describe("settings copy tense", () => {
|
||||
it("describes the Topics preview as something it will add", () => {
|
||||
expect(en.settings.preview.topics.description).toMatch(/^Will add /);
|
||||
expect(de.settings.preview.topics.description).toMatch(/sobald/);
|
||||
});
|
||||
|
||||
it("says workout routes are off for new accounts", () => {
|
||||
expect(en.settings.privacy.workoutRoutes.detail).toMatch(
|
||||
/^Off for new accounts\./,
|
||||
|
||||
@@ -146,10 +146,7 @@ describe("historical Settings addresses", () => {
|
||||
// one silently. Module pages are new in v1.44 and are allowed here.
|
||||
const listed = new Set(HISTORICAL_SETTINGS_PATHS);
|
||||
const unlisted = routable.filter(
|
||||
(path) =>
|
||||
!listed.has(path) &&
|
||||
!path.startsWith("/settings/modules/") &&
|
||||
path !== "/settings/preview",
|
||||
(path) => !listed.has(path) && !path.startsWith("/settings/modules/"),
|
||||
);
|
||||
expect(unlisted).toEqual([]);
|
||||
});
|
||||
|
||||
Reference in new issue
Block a user