From 0816b3b0c0a37c6c320001827965559de6811782 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Bombeck?= Date: Fri, 26 Jun 2026 13:14:19 +0200 Subject: [PATCH] feat(date): migrate remaining date inputs to DateField Swap the four DateInput callsites (filter bar, export range, schedule history, onboarding baseline) to DateField so the user's date-order preference paints every date input. Adapt the onChange from a native event to the direct ISO value DateField emits, and add an optional autoComplete prop so the onboarding date-of-birth field keeps its bday autofill hint. --- .../scheduling/schedule-history-timeline.tsx | 14 +++++++------- src/components/onboarding/baseline-form.tsx | 6 +++--- src/components/settings/export-section.tsx | 10 +++++----- src/components/ui/date-field.tsx | 4 ++++ src/components/ui/filter-bar.tsx | 10 +++++----- 5 files changed, 24 insertions(+), 20 deletions(-) diff --git a/src/components/medications/scheduling/schedule-history-timeline.tsx b/src/components/medications/scheduling/schedule-history-timeline.tsx index 9be638d5f..779a405d7 100644 --- a/src/components/medications/scheduling/schedule-history-timeline.tsx +++ b/src/components/medications/scheduling/schedule-history-timeline.tsx @@ -59,7 +59,7 @@ import { DialogHeader, DialogTitle, } from "@/components/ui/dialog"; -import { DateInput } from "@/components/ui/date-input"; +import { DateField } from "@/components/ui/date-field"; import { Label } from "@/components/ui/label"; import { TimesOfDayChips } from "@/components/medications/scheduling/times-of-day-chips"; import { apiDelete, apiGet, apiPatch, apiPost } from "@/lib/api/api-fetch"; @@ -545,22 +545,22 @@ function EraDialog({ - setFromDate(e.target.value)} - data-slot="zeitplan-history-from" + onChange={setFromDate} + data-testid="zeitplan-history-from" />
- setUntilDate(e.target.value)} - data-slot="zeitplan-history-until" + onChange={setUntilDate} + data-testid="zeitplan-history-until" />
diff --git a/src/components/onboarding/baseline-form.tsx b/src/components/onboarding/baseline-form.tsx index 2ca6f2d47..979f2dd33 100644 --- a/src/components/onboarding/baseline-form.tsx +++ b/src/components/onboarding/baseline-form.tsx @@ -8,7 +8,7 @@ import { toast } from "sonner"; import { Loader2 } from "lucide-react"; import { Button } from "@/components/ui/button"; -import { DateInput } from "@/components/ui/date-input"; +import { DateField } from "@/components/ui/date-field"; import { Input } from "@/components/ui/input"; import { Label } from "@/components/ui/label"; import { @@ -242,10 +242,10 @@ export function BaselineForm() { - patch("dateOfBirth", e.target.value)} + onChange={(value) => patch("dateOfBirth", value)} max={new Date().toISOString().slice(0, 10)} autoComplete="bday" /> diff --git a/src/components/settings/export-section.tsx b/src/components/settings/export-section.tsx index 8b84ce5f6..7078532a6 100644 --- a/src/components/settings/export-section.tsx +++ b/src/components/settings/export-section.tsx @@ -36,7 +36,7 @@ import { } from "lucide-react"; import { Button } from "@/components/ui/button"; -import { DateInput } from "@/components/ui/date-input"; +import { DateField } from "@/components/ui/date-field"; import { Label } from "@/components/ui/label"; import { Switch } from "@/components/ui/switch"; import { SettingsCard } from "@/components/settings/settings-card"; @@ -181,10 +181,10 @@ function DateRangeFields({ - setSince(e.target.value)} + onChange={setSince} max={until || undefined} /> @@ -192,10 +192,10 @@ function DateRangeFields({ - setUntil(e.target.value)} + onChange={setUntil} min={since || undefined} /> diff --git a/src/components/ui/date-field.tsx b/src/components/ui/date-field.tsx index 049fe5884..04255a45f 100644 --- a/src/components/ui/date-field.tsx +++ b/src/components/ui/date-field.tsx @@ -50,6 +50,8 @@ export interface DateFieldProps { onBlur?: () => void; disabled?: boolean; required?: boolean; + /** Autofill hint forwarded to the native date input (e.g. "bday"). */ + autoComplete?: string; /** ISO `yyyy-MM-dd`. */ min?: string; /** ISO `yyyy-MM-dd`. */ @@ -73,6 +75,7 @@ export const DateField = React.forwardRef( onBlur, disabled, required, + autoComplete, min, max, placeholder, @@ -174,6 +177,7 @@ export const DateField = React.forwardRef( defaultValue={value === undefined ? defaultValue : undefined} disabled={disabled} required={required} + autoComplete={autoComplete} min={min} max={max} onChange={handleNativeChange} diff --git a/src/components/ui/filter-bar.tsx b/src/components/ui/filter-bar.tsx index b27de321e..032c0c563 100644 --- a/src/components/ui/filter-bar.tsx +++ b/src/components/ui/filter-bar.tsx @@ -4,7 +4,7 @@ import * as React from "react"; import { ListFilter, X } from "lucide-react"; import { Button } from "@/components/ui/button"; -import { DateInput } from "@/components/ui/date-input"; +import { DateField } from "@/components/ui/date-field"; import { Input } from "@/components/ui/input"; import { Label } from "@/components/ui/label"; import { @@ -266,12 +266,12 @@ export function FilterBarDateRange({ > {t("dataList.dateFrom")} - onFromChange(e.target.value)} + onChange={onFromChange} />
@@ -281,12 +281,12 @@ export function FilterBarDateRange({ > {t("dataList.dateTo")} - onToChange(e.target.value)} + onChange={onToChange} />