From 0671cb6e0a9d856ac39de8da2332708a6f65c588 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Bombeck?= Date: Sun, 25 Oct 2026 00:51:33 +0200 Subject: [PATCH] chore: hold the size and version-stamp ratchets Tighten the warm-up comments in the summaries slice and the comprehensive aggregator so neither file grows past its line baseline, drop a release opener from the sharing-surface note, and record the version stamp that left the settings section list. --- src/__tests__/baselines/version-stamp-comments.json | 2 +- src/__tests__/sharing-surface-guard.test.ts | 4 ++-- src/lib/analytics/summaries-slice.ts | 12 +++++------- src/lib/insights/comprehensive-aggregator.ts | 12 +++++------- 4 files changed, 13 insertions(+), 17 deletions(-) diff --git a/src/__tests__/baselines/version-stamp-comments.json b/src/__tests__/baselines/version-stamp-comments.json index e3c126303..eb3e6f931 100644 --- a/src/__tests__/baselines/version-stamp-comments.json +++ b/src/__tests__/baselines/version-stamp-comments.json @@ -2752,7 +2752,7 @@ "lib/rollups/mood-rollups.ts": 4, "lib/rollups/tiered-context.ts": 6, "lib/score-config/rows.ts": 1, - "lib/settings/section-slugs.ts": 20, + "lib/settings/section-slugs.ts": 19, "lib/sharing/__tests__/account-access-parse.test.ts": 3, "lib/sharing/__tests__/account-access.test.ts": 2, "lib/sharing/__tests__/account-label.test.ts": 1, diff --git a/src/__tests__/sharing-surface-guard.test.ts b/src/__tests__/sharing-surface-guard.test.ts index 3cb450621..e57139b63 100644 --- a/src/__tests__/sharing-surface-guard.test.ts +++ b/src/__tests__/sharing-surface-guard.test.ts @@ -2272,8 +2272,8 @@ const ACTOR_ROUTES: Record = { * owner-only, and a delegate sees the goals only as the calendar reports them. * 270 -> 273. * - * v1.46 -- the preview-feature switch is removed with its column; the topic - * pages it was kept for were dropped. 273 -> 272. + * The preview-feature switch went with its column in the next release; the + * topic pages it was kept for were dropped. 273 -> 272. */ const FROZEN_ENTRY_COUNT = 272; diff --git a/src/lib/analytics/summaries-slice.ts b/src/lib/analytics/summaries-slice.ts index f7d481893..3d506ac52 100644 --- a/src/lib/analytics/summaries-slice.ts +++ b/src/lib/analytics/summaries-slice.ts @@ -279,13 +279,11 @@ export async function computeSummariesSlice( // One clock for every window of the slice, JS and SQL alike (see // `request-clock-sql.ts`). const now = new Date(); - // v1.4.37.1 — fire-and-forget. See `src/app/api/analytics/route.ts` - // for the full rationale: awaiting this on the read path can stall - // the event loop for tens of seconds on tenants with large iOS step - // sample sets that keep the 90-day window slightly stale. The downstream - // coverage probe falls back to live SQL for uncovered types, so - // correctness is preserved; the read just doesn't block waiting - // for the background refresh. + // v1.4.37.1 — fire-and-forget (see `src/app/api/analytics/route.ts`): + // awaiting it can stall the event loop for tens of seconds on accounts + // whose iOS steps keep the 90-day window stale, and the coverage probe + // falls back to live SQL meanwhile. Registered so the suite's settle hook + // and the statement counter can await it. trackBackgroundTask(runDetached(() => ensureUserRollupsFresh(userId))); // v1.4.36 — per-type coverage probe replaces the legacy global diff --git a/src/lib/insights/comprehensive-aggregator.ts b/src/lib/insights/comprehensive-aggregator.ts index 5f46f0cc0..6dcef4f28 100644 --- a/src/lib/insights/comprehensive-aggregator.ts +++ b/src/lib/insights/comprehensive-aggregator.ts @@ -256,13 +256,11 @@ export async function buildComprehensiveAggregate( // bp-raw, first-at, coverage-probe) without re-instrumenting. const timings: Record = {}; - // v1.4.37.1 — fire-and-forget. See `src/app/api/analytics/route.ts` - // for the full rationale: awaiting this on the read path can stall - // the event loop for 30–60 s on power-user accounts whose iOS step - // samples keep the 90-day window slightly stale. The downstream - // coverage probe falls back to live SQL for uncovered types, so - // correctness is preserved; the read just doesn't block waiting - // for the background refresh. + // v1.4.37.1 — fire-and-forget (see `src/app/api/analytics/route.ts`): + // awaiting it can stall the event loop for 30–60 s on accounts whose iOS + // steps keep the 90-day window stale, and the coverage probe falls back to + // live SQL meanwhile. Registered so the suite's settle hook and the + // statement counter can await it. trackBackgroundTask(runDetached(() => ensureUserRollupsFresh(userId))); // v1.4.36 — per-type coverage probe. The legacy global COUNT